Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ds): Move PDS members without stats to bottom of list #2766

Merged
merged 4 commits into from
Mar 7, 2024
Merged

feat(ds): Move PDS members without stats to bottom of list #2766

merged 4 commits into from
Mar 7, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Mar 6, 2024

Proposed changes

Resolves #2660

Release Notes

Milestone: 2.16.0

Changelog: Updated sorting of PDS members to show items without stats at bottom of list

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

SanthoshiBoyina1 and others added 2 commits March 6, 2024 12:20
@SanthoshiBoyina1 @t1m0thyj
reduce code duplication
af44ffa 
Signed-off-by: Santhoshi Boyina <Santhoshi.Boyina1@ibm.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj
Move PDS members without stats to bottom of list
8ff3e40 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj added this to the v2.16.0 milestone Mar 6, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.27%. Comparing base (adc6f78) to head (0327673).

Files Patch % Lines
...kages/zowe-explorer/src/dataset/ZoweDatasetNode.ts 92.85% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2766      +/-   ##
==========================================
- Coverage   93.27%   93.27%   -0.01%     
==========================================
  Files         102      102              
  Lines       10583    10580       -3     
  Branches     2300     2210      -90     
==========================================
- Hits         9871     9868       -3     
  Misses        711      711              
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

t1m0thyj added 2 commits March 6, 2024 16:35
@t1m0thyj
Fix members not shown at bottom for descending sort
22054ae 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj
Handle invalid stats when comparing nodes to sort
0327673 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

zFernand0
zFernand0 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
image

traeok
traeok approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @t1m0thyj for the feature and for condensing the logic into maintainable functions 😋

@traeok traeok merged commit a0a4121 into main Mar 7, 2024
21 of 23 checks passed
@traeok traeok deleted the feat/sort-pds-without-stats branch March 7, 2024 15:30
This was referenced Sep 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traeok traeok traeok approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@JillieBeanSim JillieBeanSim Awaiting requested review from JillieBeanSim

@awharn awharn Awaiting requested review from awharn

@rudyflores rudyflores Awaiting requested review from rudyflores

@SanthoshiBoyina SanthoshiBoyina Awaiting requested review from SanthoshiBoyina

@likhithanimma1 likhithanimma1 Awaiting requested review from likhithanimma1

Assignees

@t1m0thyj t1m0thyj

Labels
None yet
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.

[Sorting] Move PDS members without stats to bottom of list
4 participants
@t1m0thyj @zFernand0 @traeok @SanthoshiBoyina1